fix(cli-repl): lazy-load dependencies in entry point MONGOSH-1336 #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Lazy-load most dependencies in the main entry point so as not to have to evaluate their code when running mongosh in very simple cases like `--version` and `--build-info`, particularly because the cloud team needs these to be relatively fast. This results in a ~75% performance improvement for `mongosh --version`, although it is likely that that difference will be reduced later once/if we enable snapshot support.
gribnoysup approved these changes Feb 17, 2023
| @@ -1,21 +0,0 @@ | |||
| import { parseCliArgs } from './arg-parser'; | |||
There was a problem hiding this comment.
There is still reference to lib/index.js in package.json, we probably should remove it now that this file is gone? 🤔
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Lazy-load most dependencies in the main entry point so as not to have to evaluate their code when running mongosh in very simple cases like
--versionand--build-info, particularly because the cloud team needs these to be relatively fast.This results in a ~75% performance improvement for
mongosh --version, although it is likely that that difference will be reduced later once/if we enable snapshot support.(Recommend viewing diff with whitespace disabled)