Skip to content

Conversation

ScriptedAlchemy
Copy link
Member

Summary

  • update the workspace to require pnpm 10.18.1 in package metadata
  • regenerate pnpm-lock.yaml with pnpm 10
  • normalize the VS Code launch configuration formatting after pnpm regen

Testing

  • pnpm install
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 9c75a41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for module-federation-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 9c75a41
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68e48aca79455b00080175d0
Copy link

💡 Codex Review

https://github.com/module-federation/core/blob/f2ba9f6cd9869651cb1b0bcca0c7ce37226febe9/pnpm-lock.yaml#L1-L4
P1 Badge Align CI pnpm version with new lockfile format

The regenerated lockfile now declares lockfileVersion: '9.0', which pnpm only understands from v9 onward. Our CI workflows still bootstrap pnpm 8 (corepack prepare pnpm@8.11.0 in multiple .github/workflows/*.yml files), so running pnpm install there will error with a lockfile version mismatch. The workflows need to be updated to install pnpm 10 as well; otherwise every CI job will fail before executing tests.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

…t and native-federation-tests - Add force: true to rmSync to prevent ENOENT errors when directories don't exist - Ensure source directories exist before creating zip files in tests - Add directory existence checks and generate types if needed
- Format DTSManager.advance.spec.ts and DTSManager.spec.ts - Fix code formatting check failures in CI
- Move generateTypes() to beforeAll hook to ensure types are available for all tests - Remove conditional generation logic from individual tests - Add expectation checks to verify types folder exists - This ensures tests run consistently in CI where test order may vary
- Increase timeout for beforeAll hooks to 30 seconds - Fix axios mock implementation to handle multiple calls - Add proper remoteTypeUrls configuration to test setup - Include headers in mock responses for proper content type detection
- axios with responseType 'arraybuffer' expects ArrayBuffer not Buffer - Convert Node.js Buffer to ArrayBuffer when mocking arraybuffer responses - This should fix zip extraction issues in DTSManager tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant