-
- Notifications
You must be signed in to change notification settings - Fork 373
chore: bump pnpm to 10.18.1 #4119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
❌ Deploy Preview for module-federation-docs failed. Why did it fail? →
|
💡 Codex Reviewhttps://github.com/module-federation/core/blob/f2ba9f6cd9869651cb1b0bcca0c7ce37226febe9/pnpm-lock.yaml#L1-L4 The regenerated lockfile now declares ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
…t and native-federation-tests - Add force: true to rmSync to prevent ENOENT errors when directories don't exist - Ensure source directories exist before creating zip files in tests - Add directory existence checks and generate types if needed
- Format DTSManager.advance.spec.ts and DTSManager.spec.ts - Fix code formatting check failures in CI
- Move generateTypes() to beforeAll hook to ensure types are available for all tests - Remove conditional generation logic from individual tests - Add expectation checks to verify types folder exists - This ensures tests run consistently in CI where test order may vary
- Increase timeout for beforeAll hooks to 30 seconds - Fix axios mock implementation to handle multiple calls - Add proper remoteTypeUrls configuration to test setup - Include headers in mock responses for proper content type detection
- axios with responseType 'arraybuffer' expects ArrayBuffer not Buffer - Convert Node.js Buffer to ArrayBuffer when mocking arraybuffer responses - This should fix zip extraction issues in DTSManager tests
Summary
Testing