Skip to content

Conversation

CaptainWang98
Copy link
Contributor

Description

This is my second PR in this repository. 😊Please feel free to give me some feedback.

Resolve issue #3897
This pr uses return value of router.getRoutes() re-construct nested route for later usage. It has feature:

  • Turn flat routes to nested route
  • Preserve dynamic route, compare using router.options.routes which does not.
  • Acceptable time complexity - O(n)

What's next?

  • Integration Testing
  • Eage-case Testing, including some unusual route case
  • Optimize code logic, there may be redundant code

Related Issue

#3897

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.
Copy link

netlify bot commented Oct 4, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit d675cf8
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68e14cc1fdbd4d0008ecd701
😎 Deploy Preview https://deploy-preview-4117--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

changeset-bot bot commented Oct 4, 2025

⚠️ No Changeset found

Latest commit: d675cf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant