summaryReporter: Add missing cachedLogger.logBufferedMessages() call in onTestRunFinished #2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…l in onTestRunFinished Since the move to buffered logging in modernweb-dev@b2c8573. A call to `cachedLogger.logBufferedMessages();` was missing. We fix this by adding it. We call `cachedLogger.logBufferedMessages();` after reportTestFileResults but before onTestRunFinished. So the logging we do in summaryReporter. onTestRunFinished gets missed.
🦋 Changeset detectedLatest commit: 55abeb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paladox changed the title cachedLogger.logBufferedMessages() cal…cachedLogger.logBufferedMessages() call in onTestRunFinished | #2932 does a better fix. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the move to buffered logging in b2c8573. A call to
cachedLogger.logBufferedMessages();was missing. We fix this by adding it. We callcachedLogger.logBufferedMessages();after reportTestFileResults but before onTestRunFinished. So the logging we do in summaryReporter. onTestRunFinished gets missed.Fixes #2936