fix: warning UnhandledPromiseRejectionWarning not throwing with node < 15 #112
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When you use rocket lint with a version prior to node 15, when you have links errors it does not throw an error but emit a warning:
The exit code of the command is
0
and is not considered as an error.Node has changed this behavior from the version 15.0.0:
See https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode
I didn't changed the behavior your have on node 15 but it could be good to catch these errors and do a process exit instead.