Generic flatten (2d and 3d) #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merged
| LGTM |
Riccardo231 approved these changes Feb 16, 2025
OneAdder reviewed Feb 16, 2025
| | ||
| real, allocatable :: gradient(:,:,:) | ||
| real, allocatable :: gradient_2d(:,:) | ||
| real, allocatable :: gradient_3d(:,:,:) |
There was a problem hiding this comment.
Yep, I thought about that but decided not to make the code even less SOLID
There was a problem hiding this comment.
But here we have a choice between SOLID and less boilerplate, I think I agree that the second one is better
There was a problem hiding this comment.
Yes, and, most importantly for me, this approach allows for a unified API (only one flatten() for the user).
OneAdder reviewed Feb 16, 2025
src/nf/nf_flatten_layer.f90 Outdated
| | ||
| procedure :: forward_2d | ||
| procedure :: forward_3d | ||
| generic :: forward => forward_2d, forward_3d |
There was a problem hiding this comment.
Perhaps, just make it one method with assumed-rank input?
pure module subroutine forward(self, input) class(flatten_layer), intent(in out) :: self real, intent(in) :: input(..) select rank(input) rank(2) self % output = pack(input, .true.) rank(3) self % output = pack(input, .true.) rank default error stop "Unsupported rank of input" end select end subroutine forwardIt will reduce boilerplate a little
There was a problem hiding this comment.
Cool! If it works, let's do it.
| Thank you! I'll rebase and test it out! |
OneAdder approved these changes Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I attempted to make a generic
flattenso that the user doesn't need to doflatten2d. It seems like it will work.In support of
Linear2d(#197)