Skip to content

feat(SEP-973): following change Icon.sizes from string to string array #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

feat(SEP-973): following change Icon.sizes from string to string array #479

merged 1 commit into from
Oct 10, 2025
+35 −20

Conversation

@honsunrise
Copy link
Contributor

Ref:
modelcontextprotocol/modelcontextprotocol#1531

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context
@github-actions github-actions bot added T-dependencies Dependencies related changes T-test Testing related changes T-config Configuration file changes T-core Core library changes T-examples Example code changes labels Oct 9, 2025
4t145
4t145 approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@4t145 4t145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@4t145
Copy link
Collaborator

4t145 commented Oct 10, 2025

Maybe this can be considered a breaking change? Since it change the definition of Icon.
@honsunrise
Copy link
Contributor Author

It's not breaking any existing non-draft spec. So maybe it shouldn't be considered a breaking change?
@4t145 4t145 merged commit b749e3c into modelcontextprotocol:main Oct 10, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-core Core library changes T-dependencies Dependencies related changes T-examples Example code changes T-test Testing related changes

2 participants

@honsunrise @4t145