SSE custom headers #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Hello, in the newly merged rmcp, you can add custom headers by using |
Author
Nice, thank you. I had the dilemma whether to get the client or just the headers. Anyhow good to see that this SDK is starting to get going 🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add support for custom headers in SSE transport.
Motivation and Context
This change enables forwarding custom HTTP headers with SSE connections, particularly useful for authorization via bearer tokens (our use case).
This brings the Rust SDK in line with Python and TypeScript SDKs which already support this capability (links point to the relevant implementation in each repository).
How Has This Been Tested?
Implemented and tested authentication header forwarding in the example SSE client application against our server.
Breaking Changes
The
SseTransportconstructor signature has been modified: theenvparameter has been removed and replaced with headers. IDK why it was there in the first place, but if it is needed I'll put it back; probably just a copy-paste from the STDIO.Types of changes
Checklist
Additional context
This implementation replaces the previous environment variable approach with direct header management, providing a more intuitive API that aligns with standard HTTP client libraries and other SDK implementations.