Enhanced ResourceTemplate URI matching and type handling logic. #1439
+182 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Improve ResourceTemplate URI matching and type handling Fixes issue modelcontextprotocol#220 - Implemented typed-aware URI matching logic within ResourceTemplate.matches() supporting {name:str}, {id:int}, {value:float},{uuid:UUID}, and {path:path} placeholders. similar to what FastAPI supports - Added automatic type conversion and validation for URI parameters. - Updated unit tests to cover typed placeholders, numeric and float parameters, and path-based URIs. Limitations and notes: - Current implementation assumes URI templates follow a strict pattern or default to str and do not support optional parameters or wildcards beyond {path:path}.
felixweinberger added needs more eyes …g it on every match, removed bare exception added value error
| Hello, @felixweinberger, would you be able to help find someone who could review the code? Thank you! |
| related: #436 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Feature Added:
Enhanced
ResourceTemplateURI matching and type handling logic.Motivation and Context
This change introduces a typed-aware URI parsing mechanism similar to FastAPI’s path parameter system.
It resolves issue #220 by adding a more flexible and self-contained approach for handling resource URIs with type annotations.
How Has This Been Tested?
Verified functionality through new and existing unit tests for:
{name:str},{id:int},{value:float},{uuid:UUID},{path:path})Confirmed correct parameter extraction and type enforcement in all matching scenarios.
Breaking Changes
Types of changes
Checklist
Additional context
The implementation assumes URI templates follow a strict pattern and defaults to
strwhen no type is provided.Optional parameters and wildcard matching beyond
{path: path}are not supported / cannot be supported.