Recreate the library subtree #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In preparation for subtree recreation
git-subtree-dir: library git-subtree-split: 88f0106
Author
| Closing this since I've pushed the changes to main. I don't know why GitHub did not close this automatically since the head of main is the same. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I believe this solves the subtree issue. For that I did the following:
library/contractstocontracts/.library.patchwith all changes we made to the library folder, by running:subtree/library. I.e.:contractsback tolibrary/contracts.Resolves #39
Call-out
DO NOT MERGE THIS PR. AFAIK, GitHub PR merge always rewrites the history, which I'm afraid may break the sub-tree.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.