Buck build #56
Open
Buck build #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
Member
| Hi, I wanted to let you know I've seen this PR but I'm currently recovering from surgery for the next few weeks so it'll be a while before it gets integrated. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds support for builds using Buck. I wrote this build file because I am currently porting
mongo-cxx-driverto Buck, and this is a dependency.Even though
coreis header-only, the advantage of having a Buck file is that it describes which header files make up the library in a format that is human and machine readable. This description makes it is easier to integrate into another project because Buck will wire-together the include paths in an intelligent way.To "build" with Buck:
To run the tests:
The existing CMake build is unchanged; the two can coexist peacefully 😊