Skip to content

Conversation

@larsoner
Copy link
Member

On main, when you set fiducial positions using clicks, they are forced to be at one of the vertex positions on a mesh. For coarse/smooth head meshes, this unnecessarily limits the precision, sometimes causing locations to move by several millimeters from where the user clicks. This allows the actually-clicked point to be set as the fiducial location, which should work better / more precisely.

Using this on main and cilcking Lock fiducials, then unclicking Show high-resolution head, then unclicking Lock fiducials:

mne coreg --subject sample --subjects-dir ~/mne_data/MNE-sample-data/subjects 

This click is off by a lot as it snaps to the nearest vertex:

image

On this PR it lands right where I click, wherever I click:

image

This isn't a big issue for things like sample that have a good high-res head, but for some templates like our infant ones where only a low-res head is available, the points move a lot like this as well.

@larsoner
Copy link
Member Author

Had to do some SSH key gymnastics to get CircleCI to checkout properly. Not sure why, maybe some deploy key expired. One was a personal key from 2016... 🤷 Might have a deploy failure tonight, we'll see. But easy enough to iterate a bit as needed.

@larsoner
Copy link
Member Author

The macos-intel test takes a really long time so I'm going to add a slowtest dec to more tests to get the time down a bit

@drammock drammock enabled auto-merge (squash) October 14, 2025 21:05
@drammock drammock merged commit 7fb19a1 into mne-tools:main Oct 14, 2025
32 checks passed
@drammock drammock deleted the precision branch October 14, 2025 21:09
larsoner added a commit to contsili/mne-python that referenced this pull request Oct 15, 2025
* upstream/main: MAINT: Auth [skip azp] [skip actions] MAINT: Deploy [circle deploy] [skip azp] [skip actions] Bump github/codeql-action from 3 to 4 in the actions group (mne-tools#13442) ENH: Dont constrain fiducial clicks to mesh vertices (mne-tools#13445) Use timezone-aware ISO 8601 for website timestamp (mne-tools#13347) [pre-commit.ci] pre-commit autoupdate (mne-tools#13443) FIX: Update osf.io links to new format (mne-tools#13440)
larsoner added a commit to myd7349/mne-python that referenced this pull request Oct 22, 2025
* upstream/main: (46 commits) MAINT: Restore edfio git install (mne-tools#13421) Support preload=False for the new EEGLAB single .set format (mne-tools#13096) [pre-commit.ci] pre-commit autoupdate (mne-tools#13453) MAINT: Restore PySide6 6.10.0 testing (mne-tools#13446) MAINT: Auth [skip azp] [skip actions] MAINT: Deploy [circle deploy] [skip azp] [skip actions] Bump github/codeql-action from 3 to 4 in the actions group (mne-tools#13442) ENH: Dont constrain fiducial clicks to mesh vertices (mne-tools#13445) Use timezone-aware ISO 8601 for website timestamp (mne-tools#13347) [pre-commit.ci] pre-commit autoupdate (mne-tools#13443) FIX: Update osf.io links to new format (mne-tools#13440) MAINT: Ensure full checkout is used (mne-tools#13439) Add BDF export (mne-tools#13435) [pre-commit.ci] pre-commit autoupdate (mne-tools#13434) [pre-commit.ci] pre-commit autoupdate (mne-tools#13431) MAINT: Update code credit (mne-tools#13432) FIX, TST: Try to get test_export_epochs_eeeglab passing again (mne-tools#13428) FIX: Add on_few_samples parameter to core rank estimation (mne-tools#13350) MAINT: Reenable mpl nightly (mne-tools#13426) [pre-commit.ci] pre-commit autoupdate (mne-tools#13427) ...
larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 27, 2025
* upstream/main: (23 commits) ENH: Add on_missing for combine_channels (mne-tools#13463) Bump the actions group with 2 updates (mne-tools#13464) Move development dependencies into a dependency group (no more extra) (mne-tools#13452) ENH: add on_missing for rename_channels (mne-tools#13456) add advisory board to website (mne-tools#13462) ENH: Support Nihon Kohden EEG-1200A V01.00 (mne-tools#13448) MAINT: Update dependency specifiers (mne-tools#13459) ENH: Add encoding parameter to Nihon Kohden reader (mne-tools#13458) [MAINT] Automatic SPEC0 dependency version management (mne-tools#13451) FIX: Read Nihon Kohden annotation file accurately (mne-tools#13251) MAINT: Restore edfio git install (mne-tools#13421) Support preload=False for the new EEGLAB single .set format (mne-tools#13096) [pre-commit.ci] pre-commit autoupdate (mne-tools#13453) MAINT: Restore PySide6 6.10.0 testing (mne-tools#13446) MAINT: Auth [skip azp] [skip actions] MAINT: Deploy [circle deploy] [skip azp] [skip actions] Bump github/codeql-action from 3 to 4 in the actions group (mne-tools#13442) ENH: Dont constrain fiducial clicks to mesh vertices (mne-tools#13445) Use timezone-aware ISO 8601 for website timestamp (mne-tools#13347) [pre-commit.ci] pre-commit autoupdate (mne-tools#13443) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants