Allow excluded bogus runs from being plotted in the perf history #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We track performance for all of our commits (e.g. https://www.mmtk.io/ci-perf-result/master/openjdk_semispace_history.html). However, we may have some bogus runs that were recorded and plotted in the graph. This PR along with the change in
ci-perf-kit(https://github.com/mmtk/ci-perf-kit/releases/tag/0.6.7) allows us to manually exclude certain runs from being plotted in the graph.https://github.com/mmtk/ci-perf-kit/releases/tag/0.6.7 also fixes an issue that runs with no valid results will no longer be plotted as
0in the graph. Instead, the graph will show a blank result for the run.