Fix Jax WMT workload #123
Merged
Fix Jax WMT workload #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
runame added 🧱 JAX 
| MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
znado approved these changes Aug 24, 2022
| LGTM assuming we aren't tuning label smoothing |
znado requested changes Aug 24, 2022
znado approved these changes Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I wanted to wait until the hanging issue (#105) is fixed, but since it might just require a more recent jax version, I think this fix here can already be merged. See #105 for an explanation.
Besides the fix, I have also refactored the reference submission to use
workload.loss_fn().