Unstable max ar workers #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
marjune163 force-pushed the unstable-max-ar-workers branch 3 times, most recently from 5da4ee0 to 70603f3 Compare marjune163 force-pushed the unstable-max-ar-workers branch 2 times, most recently from caab098 to 363886f Compare marjune163 force-pushed the unstable-max-ar-workers branch from 363886f to 85be435 Compare 
Introduce a new `archiveWorkers` channel to limit the number of concurrent archive operations. When the limit is reached, new requests will receive a 429 Too Many Requests response. This prevents resource exhaustion and improves system stability. The maximum number of workers can be configured via the `--max-archive-workers` CLI option.
…hive-worker-limit
marjune163 force-pushed the unstable-max-ar-workers branch 2 times, most recently from 5e464f5 to 4320eac Compare marjune163 force-pushed the unstable-max-ar-workers branch from 4320eac to 63dedd2 Compare 
OlegChuev reviewed May 1, 2025
| } else { | ||
| data.Status = http.StatusTooManyRequests | ||
| } | ||
| atomic.AddUint32(h.archivingWorkers, ^uint32(0)) // archiveWorkers -= 1 |
There was a problem hiding this comment.
Can ^uint32(0) cause uint underflow? (0 - 1 -> 4294967295)
There was a problem hiding this comment.
I think in this case, this would never happened since it always added by 1 first.
| @OlegChuev as this project is claimed and designed as stateless(https://github.com/mjpclab/go-http-file-server/blob/main/README.md#tech-features), stateful variable(here |
marjune163 force-pushed the unstable branch 9 times, most recently from 55a64ae to b52e441 Compare marjune163 force-pushed the unstable branch 5 times, most recently from 972ddfb to caea005 Compare marjune163 force-pushed the unstable branch 5 times, most recently from 805d411 to 5c9954d Compare marjune163 force-pushed the unstable branch 4 times, most recently from 361e668 to fc641cb Compare marjune163 force-pushed the unstable branch 13 times, most recently from 53af32f to c0b359a Compare marjune163 force-pushed the unstable branch 2 times, most recently from bc46f7d to 271bd7d Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.