Skip to content

Conversation

ejaronne
Copy link

No description provided.

@ejaronne ejaronne marked this pull request as ready for review May 11, 2022 17:20
@ejaronne ejaronne requested a review from em-c-rod May 11, 2022 17:20
@ejaronne
Copy link
Author

@em-c-rod , if IAM_ROLE_PATH and/or IAM_ROLE_BOUNDARY are null, will that wreck the execution of the function?

@em-c-rod
Copy link
Contributor

@em-c-rod , if IAM_ROLE_PATH and/or IAM_ROLE_BOUNDARY are null, will that wreck the execution of the function?

I just added them to default to an empty string if the environment variable is not set. This seems to work with my local testing, although it gives a warning when deploying. I will leave it with that functionality right now.

@em-c-rod em-c-rod merged commit 17351e2 into ionChannel May 12, 2022
@em-c-rod em-c-rod deleted the recommended_settings branch May 12, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants