MVP saf-cli Lambda Function #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: yarick <yarick@yarick.net>
- added TODO items - paramaterized things that we have Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Added simple logging Fixed S3 get/save Signed-off-by: yarick <yarick@yarick.net>
Added winston template to match Lambda CloudWatch format Signed-off-by: yarick <yarick@yarick.net>
- adding logger to our throw/error cases - moved error checking to the top of the process so we did not start down a road that we couldn't go down for no reason - added lagger to the remaining console.log statments - fixed incorrect License reference in package.json - removed all unused commented code from files - removed unused files from project - standardized formatting and linting on files Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
aaronlippold requested review from camdenmoors, ejaronne and em-c-rod and removed request for yarick Signed-off-by: Aaron Lippold <lippold@gmail.com>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
camdenmoors reviewed Mar 4, 2022
Comment on lines +62 to +63
| const HEC_TOKEN = "473b3297-1d88-4740-96ff-e6048e51b785"; | ||
| const SPLUNK_SERVER = "splk1.efficacy.online"; |
There was a problem hiding this comment.
Might want to remove this and clear git history
Suggested change
| const HEC_TOKEN = "473b3297-1d88-4740-96ff-e6048e51b785"; | |
| const SPLUNK_SERVER = "splk1.efficacy.online"; | |
| const HEC_TOKEN = "YOUR_HEC_TOKEN"; | |
| const SPLUNK_SERVER = "YOUR_SPLUNK_SERVER"; |
camdenmoors reviewed Mar 4, 2022
app.js Outdated
| let HDF_FILE = path.resolve("/tmp/", params.Key.toString()); | ||
| Body = Body.toString(); | ||
| | ||
| const command_string = [CLI_COMMAND + ":" + CLI_FUNCTION, "-i", HDF_FILE, "-H", SPLUNK_SERVER, "-t", HEC_TOKEN]; |
There was a problem hiding this comment.
The HDF2Splunk mapper is going to be taking a username/password or token in the future once moved to the splunk-sdk library.
Splunk options: mitre/heimdall2@d183b12#diff-19410c8789053ca0d35bbdd8acd403aa1e4165ed4b17d9733d763242817e9694R21-R26
Signed-off-by: yarick <yarick@yarick.net>
# Conflicts: # app.js
em-c-rod reviewed Mar 4, 2022
app.js Outdated
| } | ||
| | ||
| // TODO: REMOVE ALL THESE COMMENTS | ||
| // TODO: Decide is we want to catch undefined saf-cli command groupings https://stackoverflow.com/questions/15201939/jquery-javascript-check-string-for-multiple-substringsa |
There was a problem hiding this comment.
I added this check in saf_action if that helps.
https://github.com/mitre/saf_action/blob/main/index.js#L9
em-c-rod reviewed Mar 4, 2022
| - main | ||
| | ||
| branches: [ main ] | ||
| pull_request: |
There was a problem hiding this comment.
Why do you want to draft releases on pull requests?
Signed-off-by: yarick <yarick@yarick.net>
Signed-off-by: yarick <yarick@yarick.net>
Signed-off-by: yarick <yarick@yarick.net>
| Closing in favor of #3 Please move your comments and reviews there |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
MVP of the
saf-clilambda function. The function will supporting reading HDF data out of an s3 bucket and providing those file(s) to the SAF CLI app and then either pushing the result to the saf convert functions end-point and or writting the result to the perscribed s3 target bucket.Items Left To Resolve
AWS Marketplace of Functions- find out what that means :)