Add annotation for apache/lucene#14874 #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikemccand approved these changes Aug 28, 2025
Owner
mikemccand left a comment
mikemccand left a comment There was a problem hiding this comment.
Yay, thanks @kaivalnp! Go benchmarks! (Uncovering an impact, positive thank god, we didn't know about).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
@mikemccand pointed me to this bump in indexing throughput for "~1 KB Wikipedia English docs, with KNN Scalar Quantized Vectors" -- see bump after
JBfrom ~32 GB/hr to ~37 GB/hr (~15%):Corresponding run: https://benchmarks.mikemccandless.com/2025.07.29.18.04.08.html
The only commit was apache/lucene#14874
This speedup seems plausible, because the same scoring function is used to score quantized float vectors (we initially thought the issue to be scoped to non-quantized byte vectors)