Subscribing to model title changes #282897
Open
+4 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rzhao271 approved these changes Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the UI to respond to chat model title changes by subscribing to model-level change events. Previously, only response-level changes within requests were being monitored.
- Adds a new observable listener for model-level changes (
added.onDidChange) - Renames the existing listener to clarify it handles request-level changes
- Both listeners now trigger UI updates when their respective change events fire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ref: #281081
Adding observable to
registerChatModelChangeListenersso we can listen and fire a change event when title changes so that the UI can reflect it