fix #282622. pin terminal serialized tool call #282887
Open
+5 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @roblourensMatched files:
|
Tyriar approved these changes Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #282622 by enabling pinning of serialized terminal tool calls from extension-contributed chat sessions. The change modifies the shouldPinPart method in the chat list renderer to distinguish between local and contributed session types.
Key Changes
- Adds logic to identify serialized terminal tool invocations from contributed sessions (sessions with custom URI schemes, not the built-in
vscodeChatInputorvscodeLocalChatSessionschemes) - Terminal tools from contributed sessions are now allowed to be pinned, while terminal tools from local sessions remain unpinned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.