Update ports and use Pylance #20
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update ports attributes following practices from the Node PR: microsoft/vscode-remote-try-node#23.
Main difference is instead of using a regex (I couldn't find a great regex for this app):
I kept "9000" but updated the in-line comment to describe the ability to use a range or regex.
Since we recently updated the vscode-dev-containers repo definitions to use Pylance, updated this sample to use Pylance as well (install language server and extension).
*I was initially just going to merge in changes to the other remote-samples following the format from the Node PR, but since it seems like not all samples may be as suited to using a regex, wanted to get another set of eyes on this PR (also since I'm updating to use Pylance).