Skip to content

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented Jan 22, 2020

For #9614

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@karrtikr karrtikr added the no-changelog No news entry required label Jan 22, 2020
@karrtikr karrtikr requested a review from karthiknadig January 22, 2020 22:30
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #9723 into master will decrease coverage by 0.16%.
The diff coverage is 20%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #9723 +/- ## ========================================== - Coverage 60.71% 60.55% -0.17%  ========================================== Files 552 552 Lines 29736 29965 +229 Branches 4495 4566 +71 ========================================== + Hits 18055 18146 +91  - Misses 10670 10798 +128  - Partials 1011 1021 +10
Impacted Files Coverage Δ
src/client/testing/main.ts 14.87% <20%> (+0.09%) ⬆️
...ence/interactive-common/intellisense/conversion.ts 30.61% <0%> (-8.52%) ⬇️
src/client/activation/refCountedLanguageServer.ts 34.78% <0%> (-5.22%) ⬇️
src/client/activation/jedi.ts 19.81% <0%> (-2.07%) ⬇️
...ience/interactive-common/interactiveWindowTypes.ts 100% <0%> (ø) ⬆️
...active-common/intellisense/intellisenseProvider.ts 41.74% <0%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784811e...20eaa8b. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karrtikr karrtikr merged commit adb7be2 into microsoft:master Jan 23, 2020
@karrtikr karrtikr deleted the testing branch January 23, 2020 21:35
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

3 participants