Sending telemetry for what language server is chosen #7442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #7442 +/- ## ========================================== + Coverage 58.56% 58.57% +<.01% ========================================== Files 494 494 Lines 21783 21782 -1 Branches 3489 3488 -1 ========================================== Hits 12758 12758 Misses 8236 8236 + Partials 789 788 -1
Continue to review full report at Codecov.
|
ericsnowcurrently approved these changes Sep 17, 2019
| }); | ||
| test('Track startup value', async () => { | ||
| state.reset(); | ||
| state |
There was a problem hiding this comment.
Should be state.setup like in line 605?
There was a problem hiding this comment.
Sorry I don't understand. Line 605 is
state.setup(s => s.updateValue(TypeMoq.It.isValue(true))).returns(() => Promise.resolve()).verifiable(TypeMoq.Times.once()); What do you mean?
There was a problem hiding this comment.
Sorry, I meant like this:
state.setup(s => s.value) .returns(() => true) .verifiable(TypeMoq.Times.exactly(2)); state.setup(s => s.updateValue(TypeMoq.It.isAny())) .returns(() => Promise.resolve()) .verifiable(TypeMoq.Times.never());
Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For #7109
[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.