Skip to content

Run smoke tests for Windows and others on CI and Nightly #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

Run smoke tests for Windows and others on CI and Nightly #7432

merged 1 commit into from
Sep 17, 2019

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Sep 17, 2019 •
edited
Loading

For #7433

Enable:

  • Windows smoke tests in PRs (wasn't there previously)
  • Smoke tests in CI (wasn't there previously)
  • Smoke tests in nightly CI (wasn't there previously)

Works on PR, CI and Nightly CI.
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Sep 17, 2019
@codecov-io
Copy link

codecov-io commented Sep 17, 2019 •
edited
Loading

Codecov Report

Merging #7432 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #7432 +/- ## ========================================== + Coverage 58.55% 58.56% +0.01%  ========================================== Files 492 492 Lines 21747 21747 Branches 3486 3486 ========================================== + Hits 12733 12737 +4  + Misses 8227 8226 -1  + Partials 787 784 -3
Impacted Files Coverage Δ
src/client/common/logger.ts 75.47% <0%> (+2.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2040777...36c1b05. Read the comment docs.
@DonJayamanne
Copy link
Author

DonJayamanne commented Sep 17, 2019

Merging as CI passes (PR, CI and Nightly CI) - All pipelines tested.
@DonJayamanne DonJayamanne merged commit 68f2163 into microsoft:master Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
@DonJayamanne DonJayamanne deleted the runSmokeTestsOnCI branch September 29, 2019 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

2 participants

@DonJayamanne @codecov-io