Skip to content

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Sep 13, 2019

For #6928

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #7384 into master will increase coverage by 0.62%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #7384 +/- ## ========================================== + Coverage 57.81% 58.44% +0.62%  ========================================== Files 493 493 Lines 21396 21782 +386 Branches 3481 3494 +13 ========================================== + Hits 12371 12731 +360  - Misses 8245 8269 +24  - Partials 780 782 +2
Impacted Files Coverage Δ
src/client/common/terminal/shellDetector.ts 100% <100%> (ø) ⬆️
src/client/datascience/debugLocationTracker.ts 69.56% <0%> (-12.44%) ⬇️
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️
...debugger/extension/configuration/resolvers/base.ts 91.3% <0%> (-5.47%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 6.01% <0%> (-0.04%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967f7b1...de640d9. Read the comment docs.

@DonJayamanne
Copy link
Author

Flaky CI

@DonJayamanne
Copy link
Author

This is crazy, flaky CI
Screenshot 2019-09-15 at 12 41 55

@DonJayamanne DonJayamanne reopened this Sep 15, 2019
@DonJayamanne DonJayamanne merged commit d5762a7 into microsoft:master Sep 15, 2019
@DonJayamanne DonJayamanne deleted the issue6929 branch September 15, 2019 09:36
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants