Davidkutu/scroll fix to release #7236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* check the position of the scroll in the interactive window, if it is at the bottom, the screen stays at the bottom, and if not, the screen stays in place. Throttling of the scroll was increased to help with consistency on rapidly appearing plots. * handle the scroll in the MainPanel, tested to work with: - regular code, -dataframes, -big and regular plots. * Added some comments.
rchiodo approved these changes Sep 5, 2019
Codecov Report
@@ Coverage Diff @@ ## release #7236 +/- ## =========================================== - Coverage 58.48% 57.66% -0.82% =========================================== Files 485 485 Lines 21437 21089 -348 Branches 3462 3457 -5 =========================================== - Hits 12537 12161 -376 - Misses 8122 8143 +21 - Partials 778 785 +7
Continue to review full report at Codecov.
|
DavidKutu pushed a commit that referenced this pull request Sep 9, 2019
* add cron job to nightly tests (#7128) (#7158) * close restart session right away (#7153) (#7161) * close restart session right away * ignore errors on await, don't want to stop and wait for shutdown * Release changes (#7183) * check the position of the scroll in the interactive (#7198) (#7236) * check the position of the scroll in the interactive window, if it is at the bottom, the screen stays at the bottom, and if not, the screen stays in place. Throttling of the scroll was increased to help with consistency on rapidly appearing plots. * handle the scroll in the MainPanel, tested to work with: - regular code, -dataframes, -big and regular plots. * Added some comments. * Turned the check of the scroll at the bottom from … (#7259) checking equal to checking a range to make it work with fractions. * Preparation for point release (#7268)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
porting #7198
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)