-   Notifications  You must be signed in to change notification settings 
- Fork 1.3k
Make it easier to add Cells #6558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add a new cell, in order to make it easier
| I don't think this is what Rong intended. You added 'Add new cell' at the end of every code lens line. I think we want to only have this on the last line of a file. It's a special case, not part of the default case. Also ALT+ENTER should be wired to match Add new cell (or whatever Jupyter normally uses for adding a new cell). #Resolved | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
add cell when you press Alt+Enter, update codewatcher.unit.test.ts to expect more code lenses
| Still not sure I like the behavior. There's an Add New cell just on the end, and the user specifies it as a code lens. But if you run current cell on the last cell, it adds a new cell anyway. Hmm. The problem I have is that the user specifies the code lens, and it doesn't show up. What if I want to add a new cell in the middle? | 
| True, I could remove it from settings and just force it to appear on the last cell. In reply to: 510949886 [](ancestors = 510949886,510685632) | 
changed the command for the keybing 'alt+enter', user can now make 'Add Cell' code lens appear anywhere he likes, but it will always appear as the last code lens in the last cell, updated codewatcher unit test to reflect the changes in code lens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
added instruction comments at the begining of imported jupyter files, and added a keybinding for alt+enter with a command that matches the behaviour in jupyter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
the codewatcher command, and returned codewatcher unit test to its original expected Code Lenses amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

unit test with correct amount of code lenses
| @@ -1,443 +1,456 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you change line endings or something on this? Not sure why the whole thing is showing up as changed.
For #6367
Added a Code Lens and a snippet to add new cells.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)