Skip to content

Conversation

@minho42
Copy link

@minho42 minho42 commented Jul 6, 2019

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jul 8, 2019
@DonJayamanne DonJayamanne added this to the 2019 - July Sprint 14 milestone Jul 8, 2019
@kimadeline
Copy link

Hi @minho42 👋 thank you for submitting this pull request! Other files got updated since you submitted it, so could you please address the conflicts between your branch and master (src/client/common/terminal/shellDetector.ts)? Feel free to request a new review when they get resolved, and I'll take a second pass 👀

Thanks!

@kimadeline kimadeline merged commit 8b69538 into microsoft:master Jul 9, 2019
@minho42 minho42 deleted the Fix-typo branch July 17, 2019 05:07
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

3 participants