Work around VSC issue with formatting on save #624 #635
Conversation
…nto lint Fix Windows terminal tests
Codecov Report
@@ Coverage Diff @@ ## master #635 +/- ## ========================================== + Coverage 60.69% 60.86% +0.17% ========================================== Files 232 232 Lines 10502 10549 +47 Branches 1830 1838 +8 ========================================== + Hits 6374 6421 +47 Misses 4122 4122 Partials 6 6
Continue to review full report at Codecov.
|
| /** | ||
| * An event that is emitted when a [text document](#TextDocument) is saved to disk. | ||
| */ | ||
| readonly onDidSaveTextDocument: Event<TextDocument>; |
There was a problem hiding this comment.
How about moving this into the DocumentManager class? (feels like it would be better in there)
https://github.com/MikhailArkhipov/vscode-python/blob/ae81702242e20902c5076f975043c416b427b82d/src/client/common/application/documentManager.ts
There was a problem hiding this comment.
It is part of the workspace in vscode, it might be worth matching vsc interfaces so it is easier to find?
There was a problem hiding this comment.
Then should we move everything from DocumentManager into workspace? I thought it would be better to move stuff related to editors into a separate class. Just as we did with the Application class.
| if (this.formatterMadeChanges | ||
| && this.contentBeforeFormatting | ||
| && !document.isDirty | ||
| && this.contentBeforeFormatting === document.getText()) { |
There was a problem hiding this comment.
Cant we use document.version to detect changes, instead of checking if file contents match.
There was a problem hiding this comment.
I'll check if it is properly changed.
2 participants
Fixes #624, #590, #124, #492