Skip to content

Fix hasCodeCells to update whenever code lens are generated. #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

Fix hasCodeCells to update whenever code lens are generated. #6226

merged 1 commit into from
Jun 18, 2019

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Jun 18, 2019

For #5879

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@rchiodo rchiodo self-assigned this Jun 18, 2019
IanMatthewHuff
IanMatthewHuff approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@DavidKutu DavidKutu closed this Jun 18, 2019
@DavidKutu DavidKutu reopened this Jun 18, 2019
DavidKutu
DavidKutu approved these changes Jun 18, 2019
View reviewed changes
Copy link

@DavidKutu DavidKutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
@rchiodo rchiodo merged commit 83dff6a into master Jun 18, 2019
@rchiodo rchiodo deleted the rchiodo/selectionSingle branch June 18, 2019 22:58
karrtikr
karrtikr reviewed Jun 18, 2019
View reviewed changes
experiments.json
@@ -1 +0,0 @@
[]
Copy link

@karrtikr karrtikr Jun 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I guess committing this deleted file was not intended.
Copy link
Author

@rchiodo rchiodo Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually delete it myself. npm run clean did.
@karrtikr karrtikr mentioned this pull request Jun 19, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants

@rchiodo @IanMatthewHuff @karrtikr @DavidKutu