Skip to content

Conversation

@ablakey
Copy link

@ablakey ablakey commented May 16, 2019

For #5642

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@msftclas
Copy link

msftclas commented May 16, 2019

CLA assistant check
All CLA requirements met.

@DonJayamanne DonJayamanne merged commit f2cb9c9 into microsoft:master May 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants