Skip to content

swap getsizeof for more relevant values #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2019
Merged

swap getsizeof for more relevant values #5371

merged 2 commits into from
Apr 19, 2019

Conversation

@IanMatthewHuff
Copy link
Member

For #5368

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@IanMatthewHuff IanMatthewHuff requested a review from rchiodo April 18, 2019 23:22
rchiodo
rchiodo approved these changes Apr 18, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@IanMatthewHuff IanMatthewHuff merged commit fb914e2 into microsoft:master Apr 19, 2019
IanMatthewHuff added a commit that referenced this pull request Apr 22, 2019
@IanMatthewHuff
swap getsizeof for more relevant values (#5371)
590978c 
* swap getsizeof for more relevant values * change size name to count
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixVarSize branch July 25, 2019 23:50
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@IanMatthewHuff @rchiodo