Skip to content

Add setting to enable/disable datascience codelens #5232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2019
Merged

Add setting to enable/disable datascience codelens #5232

merged 3 commits into from
Apr 12, 2019

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Apr 12, 2019

For #5211

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@rchiodo rchiodo requested a review from IanMatthewHuff April 12, 2019 17:07
@rchiodo rchiodo self-assigned this Apr 12, 2019
IanMatthewHuff
IanMatthewHuff approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@rchiodo rchiodo merged commit 8dbbcb8 into master Apr 12, 2019
@rchiodo rchiodo deleted the rchiodo/add_disablecodelens branch April 12, 2019 19:48
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@rchiodo @IanMatthewHuff