Skip to content

Fix problems with liveshare #4950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix problems with liveshare #4950

merged 1 commit into from
Mar 27, 2019

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Mar 27, 2019

  • Host shutdown disconnects from jupyter
  • Host direct enter should send data to the guest even if guest doesn't have
    history window open

For #4949

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@rchiodo
Fix problems with liveshare
1b770bc 
- Host shutdown disconnects from jupyter - Host direct enter should send data to the guest even if guest doesn't have history window open
@rchiodo rchiodo requested a review from IanMatthewHuff March 27, 2019 00:09
@rchiodo rchiodo self-assigned this Mar 27, 2019
IanMatthewHuff
IanMatthewHuff approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@rchiodo rchiodo merged commit 56ac9fe into master Mar 27, 2019
@rchiodo rchiodo deleted the rchiodo/host_shutdown branch March 27, 2019 00:26
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@rchiodo @IanMatthewHuff