Skip to content

Fixing validation of 'Improvements to message displayed when python path is invalid (in launch.json)' #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2019
Merged

Fixing validation of 'Improvements to message displayed when python path is invalid (in launch.json)' #4136

merged 2 commits into from
Jan 25, 2019

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented Jan 24, 2019 •
edited
Loading

For PR #4011 issue #3661

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
@karrtikr karrtikr added the no-changelog No news entry required label Jan 24, 2019
@codecov
Copy link

codecov bot commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #4136 into master will increase coverage by 1%.
The diff coverage is 90%.

@@ Coverage Diff @@ ## master #4136 +/- ## ====================================== + Coverage 79% 79% +1%  ====================================== Files 408 408 Lines 18769 18774 +5 Branches 3034 3034 ====================================== + Hits 14725 14762 +37  + Misses 4041 4009 -32  Partials 3 3
Flag Coverage Δ
#Linux 68% <70%> (ø) ⬇️
#Windows 69% <70%> (+1%) ⬆️
#macOS 68% <70%> (ø) ⬇️
DonJayamanne
DonJayamanne requested changes Jan 24, 2019
View reviewed changes
@karrtikr karrtikr changed the title Corrected PR #4011 Fixing validation of 'Improvements to message displayed when python path is invalid (in launch.json)' Jan 24, 2019
@DonJayamanne DonJayamanne merged commit 150cf62 into microsoft:master Jan 25, 2019
DonJayamanne pushed a commit that referenced this pull request Jan 25, 2019
@DonJayamanne
Fixing validation of 'Improvements to message displayed when python p…
6ed1f95 
…ath is invalid (in launch.json)' (#4136) * added pythonPathSource information * Code reviews
@karrtikr karrtikr deleted the correctPR4011 branch January 25, 2019 17:45
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

2 participants

@karrtikr @DonJayamanne