Make python interactive prompt up/down behave like terminal window #4126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Get rid of saving current user input. Not consistent with terminal
Codecov Report
@@ Coverage Diff @@ ## master #4126 +/- ## ====================================== + Coverage 79% 79% +1% ====================================== Files 408 408 Lines 18765 18804 +39 Branches 3031 3046 +15 ====================================== + Hits 14719 14762 +43 + Misses 4043 4034 -9 - Partials 3 8 +5
|
| | ||
| private move(dir: number) { | ||
| if (this.pos !== undefined) { | ||
| let result : number | undefined = this.pos + dir; |
There was a problem hiding this comment.
t [](start = 21, length = 2)
Did you run hygiene? I see lots of spaces like this.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For #4092
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)