Fix onInterpreterChange event to only fire on interpreter change #3847
Conversation
| // Check if we actually changed our python path | ||
| const pySettings = this.configService.getSettings() as PythonSettings; | ||
| if (this.pythonPathSetting !== pySettings.pythonPath) { | ||
| this.pythonPathSetting = pySettings.pythonPath; |
There was a problem hiding this comment.
pythonPath [](start = 48, length = 10)
Is this the only thing that can change for an intrepreter? What if I had two virtualenvs with the same path but different names? (Not sure if that's possible or not)
There was a problem hiding this comment.
@rchiodo Yeah, I was a touch worried that I'm being too naive with this check. I'm not checking in until Don takes a look as I assume that he would know best on that. Might need to check more (venvpath condapath) in addition to the python path. I'll give the venv stuff a look myself now just for kicks.
There was a problem hiding this comment.
Hi @IanMatthewHuff I too came across this issue in another PR of mine and had to change it. Please can we put this on hold for my PR.
| @DonJayamanne Totally. I'll hold off, no problem. |
3 participants
For #3749
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)