Skip to content

Add remote functional test #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 18, 2018
Merged

Add remote functional test #3741

merged 4 commits into from
Dec 18, 2018

Conversation

@IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Dec 18, 2018

For #3714

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
DonJayamanne
DonJayamanne requested changes Dec 18, 2018
View reviewed changes
DonJayamanne
DonJayamanne approved these changes Dec 18, 2018
View reviewed changes
src/test/datascience/notebook.functional.test.ts
if (urlMatch) {
return urlMatch[0];
}
return undefined;
Copy link

@DonJayamanne DonJayamanne Dec 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - You don't need to explicitly return undefined.
Just having a plain return; statement is the same as return undefined;
@IanMatthewHuff IanMatthewHuff merged commit 4dab144 into microsoft:master Dec 18, 2018
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/remoteConnectTest branch December 18, 2018 21:48
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@IanMatthewHuff @DonJayamanne