Skip to content

Conversation

@karthiknadig
Copy link
Member

For #2463

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Result of setting showReturnValue: true
image

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, any concerns @DonJayamanne?

Also, please fix the merge conflicts before committing.

.gitignore Outdated
.pytest_cache
tmp/**
.python-version
**/.vs/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think simply putting this to:

.vs/

would suffice?

},
"showReturnValue": {
"type": "boolean",
"description": "Show return value of functions when stepping.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@DonJayamanne DonJayamanne merged commit 618f6d7 into microsoft:master Oct 11, 2018
@karthiknadig karthiknadig deleted the retval branch July 29, 2019 18:00
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants