add std out to subprocess to stop overflow #21758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eleanorjboyd added the bug 
connor4312 reviewed Aug 4, 2023
connor4312 approved these changes Aug 4, 2023
| added skip-test label because test mocks were updated (which lead to the tests working again) but this file pattern is not caught under the CLI review. |
karthiknadig requested changes Aug 4, 2023
eleanorjboyd changed the base branch from main to feature-branch-testing-overflow-bug-fix karthiknadig approved these changes Aug 10, 2023
eleanorjboyd merged commit 461fb91 into microsoft:feature-branch-testing-overflow-bug-fix eleanorjboyd added a commit that referenced this pull request Aug 14, 2023
Displays output to the user and ensures the subprocess doesn't run into buffer overflow. Bug was introduced with the switch to the execObservable in #21667. Only occurs for large repos where output from pytest was large enough to reach buffer overflow.
eleanorjboyd added a commit that referenced this pull request Aug 14, 2023
Displays output to the user and ensures the subprocess doesn't run into buffer overflow. Bug was introduced with the switch to the execObservable in #21667. Only occurs for large repos where output from pytest was large enough to reach buffer overflow.
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Aug 14, 2023
Displays output to the user and ensures the subprocess doesn't run into buffer overflow. Bug was introduced with the switch to the execObservable in microsoft#21667. Only occurs for large repos where output from pytest was large enough to reach buffer overflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Displays output to the user and ensures the subprocess doesn't run into buffer overflow. Bug was introduced with the switch to the execObservable in #21667. Only occurs for large repos where output from pytest was large enough to reach buffer overflow.