Skip to content

Conversation

@DonJayamanne
Copy link

Fixes #1811

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
@brettcannon
Copy link
Member

We should @bstaint co-authorship credit for finding the root cause.

@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #1812 into master will decrease coverage by 0.13%.
The diff coverage is 61.9%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1812 +/- ## ========================================== - Coverage 74.37% 74.23% -0.14%  ========================================== Files 282 282 Lines 13218 13144 -74 Branches 2375 2357 -18 ========================================== - Hits 9831 9758 -73  + Misses 3256 3253 -3  - Partials 131 133 +2
Impacted Files Coverage Δ
src/client/activation/classic.ts 91.83% <100%> (+0.53%) ⬆️
src/client/providers/symbolProvider.ts 59.37% <57.89%> (-22.63%) ⬇️
src/client/language/braceCounter.ts 81.08% <0%> (-13.52%) ⬇️
src/client/common/variables/environment.ts 92.45% <0%> (-4.92%) ⬇️
src/client/debugger/PythonProcess.ts 49.58% <0%> (-1.67%) ⬇️
src/client/interpreter/locators/index.ts 90% <0%> (-1.49%) ⬇️
...lient/debugger/configProviders/pythonV2Provider.ts 83.33% <0%> (-1.05%) ⬇️
src/client/extension.ts 96.96% <0%> (-0.05%) ⬇️
src/client/common/types.ts 100% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b374e...d52071f. Read the comment docs.

@brettcannon
Copy link
Member

So bstaint said they didn't want to sign the CLA, so I tweaked the phrasing to say he provided a diagnosis of the problem since we didn't directly take any code from them.

@DonJayamanne DonJayamanne merged commit aa578fc into microsoft:master Jun 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants