Skip to content

Conversation

@DonJayamanne
Copy link

Fixes #1484

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, and learned something new as well (we can break into HTML & template code. Nice touch).

@d3r3kk
Copy link

d3r3kk commented May 2, 2018

CI has trouble, looks like this line?

prospector 0.12.7 has requirement pycodestyle==2.0.0, but you'll have pycodestyle 2.3.1 which is incompatible. 
@DonJayamanne
Copy link
Author

There's a separate issue for that, can be ignored.

@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #1575 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1575 +/- ## ========================================== - Coverage 71.65% 71.42% -0.23%  ========================================== Files 273 273 Lines 12700 12700 Branches 2282 2282 ========================================== - Hits 9100 9071 -29  - Misses 3465 3493 +28  - Partials 135 136 +1
Impacted Files Coverage Δ
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 53.33% <0%> (-20.01%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/common/installer/productInstaller.ts 60.31% <0%> (-4.24%) ⬇️
src/client/linters/baseLinter.ts 88.54% <0%> (-3.13%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (-0.66%) ⬇️
src/client/debugger/mainV2.ts 75.8% <0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5127486...2f5e5a7. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 4bb0644 into microsoft:master May 7, 2018
@DonJayamanne DonJayamanne deleted the issue1484 branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants