Remove cell index property and use build in prop #14239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DonJayamanne requested review from DavidKutu, IanMatthewHuff, greazer, joyceerhl and rchiodo 
Codecov Report
@@ Coverage Diff @@ ## main #14239 +/- ## ========================================== - Coverage 59.95% 59.93% -0.02% ========================================== Files 706 706 Lines 39184 39181 -3 Branches 5681 5681 ========================================== - Hits 23493 23484 -9 - Misses 14454 14457 +3 - Partials 1237 1240 +3
Continue to review full report at Codecov.
|
| Kudos, SonarCloud Quality Gate passed!
|
IanMatthewHuff approved these changes Oct 2, 2020
rchiodo approved these changes Oct 2, 2020
DonJayamanne added a commit that referenced this pull request Oct 30, 2020
* Remove cell index property and use build in prop (#14239) * Update other cells in cell execution (#14240) * Tests for prompting to install missing ipykernel (#14266) * Treat Native notebook tests as VS Code tests (#14282) * Fixes to blowing away of kernel info & not using right startup info (… … * Default cell language for native notebooks (#14314) * Ignore formatting in ipynb when dealing with trust (#14333) * Fixes to trust service (#14352) * Change `IPython kernel` to `Jupyter kernel` (#14375) * Trust for native notebooks (#14353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.