Skip to content

Conversation

@IanMatthewHuff
Copy link
Member

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.
@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Aug 13, 2020
@IanMatthewHuff
Copy link
Member Author

Tried to take some notes on the release process while I was doing it, and clean up some wording that was unclear to me. Looping in some folks involved with recent releases to see if they agree with my changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #13415 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #13415 +/- ## ========================================== - Coverage 59.92% 59.90% -0.03%  ========================================== Files 670 670 Lines 37208 37207 -1 Branches 5312 5311 -1 ========================================== - Hits 22297 22287 -10  - Misses 13774 13780 +6  - Partials 1137 1140 +3 
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
...ient/datascience/jupyter/kernels/kernelSelector.ts 67.93% <0.00%> (-0.18%) ⬇️
...nt/datascience/jupyter/kernels/kernelSelections.ts 84.21% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff739c...42b37ea. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit f47defc into microsoft:master Aug 13, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/releasePlanUpdates branch August 13, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

4 participants