Skip to content

Conversation

@IanMatthewHuff
Copy link
Member

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.
David Kutugata and others added 6 commits August 6, 2020 14:34
…ft#13296) * Add gather status bar and update survey link (microsoft#13225) * add status bar * add localization * Added news file * add a 2 second timeout * updated the gather survey link * Change the gather icon while gathering * moved the gathering redux function to interactive common added a constant * move css to common.css * removed the status bar message * changed noop import * update changelog
Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com>
…dings for most new interactive window cell commands (microsoft#13334) (microsoft#13348) * Add Goto Prev/Next Cell * Add goto previous cell * Remove unneeded changes * Add default keybindings for cell commands * Goto should be Go to Co-authored-by: Jim Griesmer <jimg@live.com> Co-authored-by: Jim Griesmer <jimg@live.com>
) Code change can only affect new keyboard shortcut operations
* update version number and npm install to update package-lock.json * update changelog version and date * update news for changelog.md * update generated TPN Co-authored-by: Ian Huff <ianhuff@ravikun-dev2.redmond.corp.microsoft.com>
@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Aug 13, 2020
@IanMatthewHuff
Copy link
Member Author

Last release process step. Merging release changes back into master branch.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #13412 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #13412 +/- ## ========================================== - Coverage 59.92% 59.90% -0.03%  ========================================== Files 670 670 Lines 37208 37208 Branches 5312 5312 ========================================== - Hits 22297 22288 -9  - Misses 13774 13780 +6  - Partials 1137 1140 +3 
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff739c...7258f32. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 0c6f631 into microsoft:master Aug 13, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/updateMasterFromRelease branch August 13, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

5 participants