Skip to content

Conversation

@MikhailArkhipov
Copy link

Pylance does not support per-folder LS instances and MPLS v1 does not reliably work in this case anyway. This simplifies transition of setting from v1 to Pylance.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.

- [ ] Has a news entry file (remember to thank yourself!).
- [ ] Appropriate comments and documentation strings in the code.
- [ ] Has sufficient logging.
- [ ] Has telemetry for enhancements.
- [ ] Unit tests & system/integration tests are added/updated.
- [ ] Test plan is updated as appropriate.
- [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
- [ ] The wiki is updated with any design decisions/details.

@MikhailArkhipov MikhailArkhipov added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. internal contributor labels Aug 3, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #13246 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #13246 +/- ## ========================================== + Coverage 59.64% 59.80% +0.15%  ========================================== Files 670 670 Lines 36830 37235 +405 Branches 5188 5286 +98 ========================================== + Hits 21968 22268 +300  - Misses 13770 13833 +63  - Partials 1092 1134 +42 
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/datascience/jupyter/jupyterSession.ts 73.68% <0.00%> (-3.43%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...science/notebookStorage/notebookStorageProvider.ts 50.00% <0.00%> (-1.73%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
...datascience/interactive-common/notebookProvider.ts 52.50% <0.00%> (-0.52%) ⬇️
...datascience/notebookStorage/nativeEditorStorage.ts 68.13% <0.00%> (-0.47%) ⬇️
src/client/datascience/types.ts 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96044d9...38ad0c5. Read the comment docs.

@MikhailArkhipov MikhailArkhipov added the no-changelog No news entry required label Aug 3, 2020
@MikhailArkhipov MikhailArkhipov marked this pull request as ready for review August 3, 2020 21:56
@jakebailey
Copy link
Member

I'm sure you tested it, but did you notice any oddities? I know we already have loads of settings set to "resource" that really shouldn't be, but are.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, seems to work fine in the expected cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. no-changelog No news entry required

3 participants