Skip to content

Fix nightly data science IOC container and fix service spelling #12810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Fix nightly data science IOC container and fix service spelling #12810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
391b8b1
add new services and rename incorrectly named service
Jul 8, 2020
c0ae157
add news
Jul 8, 2020
008bc1e
remove unused import
Jul 8, 2020
2ae7b24
use the helper function to register IOC types
Jul 8, 2020
e284755
merge with master
Jul 8, 2020
e9dac78
actually save files
Jul 8, 2020
6c76070
file accidentally added back in over merge
Jul 8, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/3 Code Health/12809.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add new services to data science IOC container and rename misspelled service.
1 change: 1 addition & 0 deletions src/test/datascience/dataScienceIocContainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,6 +1077,7 @@ export class DataScienceIocContainer extends UnitTestIocContainer {

// Make sure full interpreter services are available.
registerInterpreterTypes(this.serviceManager);
registerForIOC(this.serviceManager);

// Rebind the interpreter display as we don't want to use the real one
this.serviceManager.rebindInstance<IInterpreterDisplay>(IInterpreterDisplay, interpreterDisplay.object);
Expand Down