Fixes to reverting notebooks #12410
Merged
Fixes to reverting notebooks #12410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DonJayamanne requested review from DavidKutu, IanMatthewHuff, greazer, joyceerhl, rchiodo and techwithtim 
| Kudos, SonarCloud Quality Gate passed!
|
rchiodo approved these changes Jun 17, 2020
DavidKutu approved these changes Jun 17, 2020
| } | ||
| const model = await this.notebookStorage.load(uri, undefined, !openContext.backupId); | ||
| // If there's no backup id, then skip loading dirty contents. | ||
| const model = await (openContext.backupId |
There was a problem hiding this comment.
Out of typescript noob interest. Why doesn't notebookStorage.load unify the last boolean | string type up the method chain?
There was a problem hiding this comment.
TS isn't smart enough, it didn't work, the union type doesn't work across overloaded functions. if we want to use union type then the argument needs to be a union type.
Hate it., looks super sucky
There was a problem hiding this comment.
Bleh, well that make sense. Just looked funny to me.
IanMatthewHuff approved these changes Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For #10496