Skip to content

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented May 15, 2020

For #11789

${config:python.interpreterPath} worked fine for launch.json but not for tasks.json. Having a command works for both. So I've renamed all instances of ${config:python.interpreterPath} to ${command:python.interpreterPath} to be consistent. Also did the migrations.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #11840 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #11840 +/- ## ======================================= Coverage 60.45% 60.46% ======================================= Files 631 632 +1 Lines 34156 34179 +23 Branches 4798 4800 +2 ======================================= + Hits 20648 20665 +17  - Misses 12508 12512 +4  - Partials 1000 1002 +2 
Impacted Files Coverage Δ
...on/diagnostics/checks/invalidLaunchJsonDebugger.ts 94.11% <100.00%> (+0.07%) ⬆️
.../diagnostics/checks/invalidPythonPathInDebugger.ts 86.36% <100.00%> (ø)
src/client/common/constants.ts 100.00% <100.00%> (ø)
...onfiguration/launch.json/interpreterPathCommand.ts 100.00% <100.00%> (ø)
...debugger/extension/configuration/resolvers/base.ts 91.02% <100.00%> (ø)
src/client/debugger/extension/serviceRegistry.ts 100.00% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974e784...6dce3b2. Read the comment docs.

@karrtikr karrtikr merged commit bcac5c1 into microsoft:master May 19, 2020
@karrtikr karrtikr deleted the to branch May 19, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants