Skip to content

Allow interrupting the kernel more than once #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

Allow interrupting the kernel more than once #11184

merged 1 commit into from
Apr 15, 2020
+35 −27

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 15, 2020

For #10587, #10356
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication
rchiodo
rchiodo approved these changes Apr 15, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
rchiodo
rchiodo reviewed Apr 15, 2020
View reviewed changes
news/2 Fixes/10356.md
@@ -0,0 +1 @@
Cancelling the prompt to restart the kernel should not leave the toolbar buttons disabled.
Copy link

@rchiodo rchiodo Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's still one more must fix for april that we have to finish
Copy link
Author

@DonJayamanne DonJayamanne Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you are referring to Save Notebooks, if thats it then I've submitted a PR for that.
@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #11184 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #11184 +/- ## ========================================== - Coverage 61.45% 61.41% -0.04%  ========================================== Files 596 596 Lines 32874 32883 +9 Branches 4659 4659 ========================================== - Hits 20203 20196 -7  - Misses 11654 11668 +14  - Partials 1017 1019 +2
Impacted Files Coverage Δ
.../datascience/interactive-common/interactiveBase.ts 5.53% <0.00%> (-0.09%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d356f...4850102. Read the comment docs.
@DonJayamanne DonJayamanne merged commit 7846e30 into microsoft:master Apr 15, 2020
@DonJayamanne DonJayamanne deleted the issue10587 branch April 15, 2020 18:45
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo